Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASP.NET] Migrate to native Activity Status and Status Desc #651

Merged
merged 12 commits into from
Sep 23, 2022
Merged

[ASP.NET] Migrate to native Activity Status and Status Desc #651

merged 12 commits into from
Sep 23, 2022

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Sep 20, 2022 •
edited
Loading

Fixes 3112

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

@vishweshbankwar vishweshbankwar changed the title Migrate to native Activity Status and Status Desc [ASP.NET] Migrate to native Activity Status and Status Desc Sep 20, 2022
@vishweshbankwar vishweshbankwar marked this pull request as ready for review September 20, 2022 00:27
@vishweshbankwar vishweshbankwar requested a review from a team September 20, 2022 00:27
@codecov
Copy link

codecov bot commented Sep 20, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@27bac99). Click here to learn what that means.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #651   +/-   ##
=======================================
  Coverage        ?   77.78%           
=======================================
  Files           ?      171           
  Lines           ?     5158           
  Branches        ?        0           
=======================================
  Hits            ?     4012           
  Misses          ?     1146           
  Partials        ?        0
Impacted Files Coverage Δ
...OpenTelemetry.Instrumentation.AspNet/SpanHelper.cs 75.00% <75.00%> (ø)
...umentation.AspNet/Implementation/HttpInListener.cs 88.31% <100.00%> (ø)

@utpilla utpilla added the comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet label Sep 20, 2022
@cijothomas cijothomas merged commit 58cf8d7 into open-telemetry:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas left review comments

@utpilla utpilla utpilla approved these changes

@Yun-Ting Yun-Ting Yun-Ting approved these changes

Assignees
No one assigned
Labels
comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Status and StatusDescription from Activity class.
4 participants
@vishweshbankwar @cijothomas @Yun-Ting @utpilla